[DMA 5/8]: Clean up macros #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
dma3
branch
4 times, most recently
from
3af506e to
e10b28f
Compare
|
fwiw, the last commit LGTM. (Idk if it's easier to get this in earlier to avoid rebasing it) |
|
I'm rebasing this PR over and over again so that I can have an overview of what I'm missing. The idea of the macro dedup came a bit too late, I'd rather not pull it up and rebase over it, especially since it doesn't matter that much. |
bugadani
force-pushed
the
dma3
branch
2 times, most recently
from
6b27763 to
44a0ea1
Compare
bugadani
commented
Nov 13, 2024
bugadani
changed the title
bugadani
changed the title
Dominaezzz
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This PR mostly cleans up macros and interrupt handlers (reducing the number of locations we need to edit), but also refactors the PDMA macro a bit in preparation for CryptoDMA support.
Testing
Describe how you tested your changes.